various: fix hostPlatform.canExecute buildPlatform #367175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfgangwalther
commented
Dec 21, 2024
github-actions
bot
added
10.rebuild-darwin: 0
It doesn't matter whether the hostPlatform could execute stuff from the buildPlatform - we need it the other way around: Certain things during a build process can only happen when, as part of the build, the **buildPlatform** can execute the code it just created for the **hostPlatform**. Unless we are talking about compilation at run-time, as in the case of PostgreSQL. Extend the comment there to make it clear that this is on purpose. Another case that's OK is vlc, where luac can't cross-compile at build time, thus the bytecode is actually build for the buildPlatform and the sources must be interpreted at runtime instead.
wolfgangwalther
force-pushed
the
can-execute-host-platform
branch
from
b9af1c1 to
0010ba2
Compare
Ma27
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't matter whether the hostPlatform could execute stuff from the buildPlatform - we need it the other way around: Certain things during a build process can only happen when, as part of the build, the buildPlatform can execute the code it just created for the hostPlatform.
Unless we are talking about compilation at run-time, as in the case of PostgreSQL. Extend the comment there to make it clear that this is on purpose.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.